Repository navigation
fix(launcher): give the Apps tile its own icon and align app search - #47
Draft
manuel-rtsch wants to merge 2 commits into
Draft
manuel-rtsch wants to merge 2 commits into
manuel-rtsch wants to merge 2 commits into
Conversation
Apps and Sideport both used SidekitIcon.DeployedCode, so the two launcher tiles were visually identical. Apps now uses a new Material Symbols 'apps' grid glyph; Sideport keeps DeployedCode, which it already uses for ported app tiles and the 'In Sideport' row.
- AppRow reserves the icon slot, so rows no longer shift while icons load. - Apps list fade uses the real row index instead of a hardcoded +2. - Launcher search uses matchesApp, so T9 queries find the same apps as the Apps list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
The launcher's Apps tile and Sideport tile used the same glyph (
SidekitIcon.DeployedCode), so two different destinations looked identical in the grid, the list, Arrange apps and Hidden apps.sk_ic_appsdrawable (Material Symbols Roundedapps, 3×3 dot grid), added asSidekitIcon.Apps. Sideport keepsDeployedCode, which it already uses for ported app tiles and the "In Sideport" row on an app's page.matchesApp, the same matcher as the Apps list. Previously the launcher only did a case-insensitive substring match, so a T9 query (627→ Maps) found the app in the Apps list but not on home.AppRowreserves the icon slot, so rows no longer shift sideways while an app's icon is still loading.+2, so rows keep their fade when the error/message banner is shown.No issue linked; found while reviewing the launcher grid.
How to test
627: Maps is the only result. Type6245: Mail. Compare with the same query in the Apps app — results should match.Real-device testing
407be58627→ Maps only;6245→ Mail only. Pass (matches the Apps list).Checklist
mainand this PR targetsmain.Build and automated test results
./gradlew :app:compileDebugKotlin— success../gradlew :app:testDebugUnitTest— success (full unit suite, includingLauncherSearchTest,LauncherResolveTest,LauncherViewModelTest)../gradlew :app:installDev— built, but the install step failed withINSTALL_FAILED_VERSION_DOWNGRADEbecause the device already had a dev build from a branch with a higher commit count. Installed the same APK withadb install -r -d app/build/outputs/apk/dev/app-dev.apk— success,versionName=1.1-101-g407be58-dev.roborazzi.test.record=truelocally, so screenshot tests rewrite goldens rather than compare. The launcher grid goldens are unchanged by this PR (the Apps tile sits below the fold in that frame), so no golden updates are included.Known issues and exceptions
matchesApp. A launcher-level T9 test would be the natural addition — happy to add one if you want it in this PR.InstalledTile/InstalledAppIcondo not exist onmainyet.Maintainer review
Changes to
mainrequire approval from @HarlenPostill. Request review only when the required testing is complete.