Repository navigation
feat(settings): consolidate keypad preferences on a Keyboard settings page - #42
Open
manuel-rtsch wants to merge 6 commits into
Open
manuel-rtsch wants to merge 6 commits into
manuel-rtsch wants to merge 6 commits into
Conversation
(cherry picked from commit 335361e)
(cherry picked from commit 1ed739c)
(cherry picked from commit 039e5ce)
The Keyboard feature commits were authored on the integration branch, whose screenshots were recorded with the compact layout. Re-recorded here on main so the committed images match this branch's code and ./gradlew test leaves the tree clean.
manuel-rtsch
force-pushed
the
pr/keyboard-settings
branch
from
November 9, 2026 07:03
c146263 to
c790a06
Compare
Share the Item API with HarlenPostill#45 so the two branches merge cleanly, and leave the Sundial demo layout to HarlenPostill#44.
manuel-rtsch
added a commit
to manuel-rtsch/Sidekit
that referenced
this pull request
Nov 10, 2026
Share the Item API with HarlenPostill#42 so the two branches merge cleanly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Settings > Keyboard — one page for the keypad preferences that used to be four separate rows on the Settings home: the module, the input mode, the Back key accessibility service and the custom mapping, with the key diagram underneath. (
KeyboardSettingsScreen.kt,SettingsScreen.kt,KeypadDemo.kt)KeypadDemofor the active module (newidleHintparameter).keyboard_settings_page.png) and the resulting Settings home (re-recordedsettings_system_home.png) are committed;keypad_mapping_settings.pngis replaced by the page's own baseline.Rows that act in place vs rows that open a page (
Item.kt)SidekitItemgainssecondaryToEnd(toggle values right-aligned) andshowLinkArrownow draws the arrow whether or not a value is present, so a row reads as "this changes here" or "this opens another page" without a second convention. Settings uses the split: Launcher default and Compact layout stay compact toggle rows, Home app stays compact (it opens a system dialog), and Arrange apps / Case colour / Keyboard are full rows with the arrow.Tests —
KeypadMappingUiTestupdated for the new route and rows.Branch state
The branch is rebased directly onto current
upstream/main(3debe06). The obsolete merge history and the duplicate screenshot-baseline commit from the old branch are gone. The work is now five focused commits: the four Keyboard commits plusApply Spotless formatting.How to test
./gradlew :app:testDebugUnitTestthengit status --short— must print nothing.Real-device testing
c790a06— the latest commit,a13dd17, only applies Spotless formatting and does not change behavior.devbuild, opened Settings → Keyboard, exercised module cycling, Input mode, Mapping and Back navigation, and checked that the key diagram follows the active module. The run was satisfactory.keyboard_settings_home.png,keyboard_settings_page.pngare committed.Checklist
mainand this PR targetsmain.Documentation remains unchecked:
docs/keypad-mapping.mddescribes the mapping editor, not the Settings rows. Say if you want the Keyboard page added there.Build and automated test results
Run on
a13dd17, parent3debe06:./gradlew spotlessCheck :app:testDebugUnitTest— success; 392 app tests and 34sidekittests, 0 failures.git status --shortafterwards: empty../gradlew :app:assembleDebug :app:lintDebug :sidekit:testDebugUnitTest— success;lintDebugcompleted with no errors../gradlew spotlessCheck— success after applying formatting.Known issues and exceptions
roborazzi.test.record=trueis hardcoded inapp/build.gradle.kts, so the only signal is the dirty tree after a local run. Unchanged frommain.Maintainer review
Changes to
mainrequire approval from @HarlenPostill. Request review only when the required testing is complete.