fix(vscode): the private CLI copy fetches a declared version - #155
Merged
Merged
Conversation
…1/3) C-27 paired the extension's private CLI copy to the extension's own version number. That pairing blocked the first stable publication of the C-34 fix: 0.15.1 is already on the Marketplace as a pre-release, the Marketplace never accepts a version number twice, and a 0.15.2 extension would have fetched a CLI 0.15.2 that does not exist, failing exactly the fresh-user case the human gate had just passed. C-27 now names the default: package.json's specterCli.default, which must equal the repository's VERSION file and satisfy specterCli.range. The extension's own number is free to move without a CLI release. AC-50 reads the declared default. AC-83 binds the field's presence and form, its equality with VERSION, its place inside the range, and the three settings cases: empty uses the default, latest is passed through for the caller to resolve, a pinned value is used as is; a build without the field cannot resolve a private copy and says so. spec-vscode 6.0.0 to 7.0.0, major: an implementation that reads its own version no longer conforms. Dogfood drops by one criterion until commit 2.
Eight runtime assertions, reached through require() so tsc stays clean, and all eight fail on arrival: privateVersionFor does not exist, so the empty, latest, pinned, and missing-field cases fail with a TypeError, and package.json declares no specterCli.default, so the form, the equality with VERSION, and the range case fail, the last because satisfiesRange throws on an undefined version rather than passing it. Committed with --no-verify: the hook stops on the red tests.
…(3/3) privateVersionFor decides the private copy's version from package.json's specterCli.default and the specter.version setting: empty uses the default, latest is passed through for the wrapper to resolve, a pinned value is used as is, and a build without the field is reported as broken rather than guessed at. resolvePrivateVersion in extension.ts now calls it. package.json declares 0.15.1, which AC-83 binds to the repository's VERSION file and to the range. The two Makefile gates that paired the numbers move with it. version-sync now writes VERSION into specterCli.default and leaves the extension's own version alone. release-check names the VSIX after package.json's version. publish-vscode takes the token from VSCE_PAT in the environment and never puts it on the command line; the PAT= argument form is gone. Gates: tsc clean, eslint zero errors, jest 358 of 358, extension builds, version-sync on an in-sync tree changes nothing. Committed with --no-verify for an environmental reason, not a red test: the pre-commit hook runs make check, and on this machine the five spec-watch tests fail because this user holds 124 of 128 inotify instances (47 in VS Code, 12 in another agent, 6 in this one), so specter watch cannot open a watcher. The same test fails identically on an untouched checkout of main here. No Go file changes in this commit; CI on a clean runner is the Go gate for this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The extension's private CLI copy defaulted to the extension's own version number. That pairs every extension version to a CLI release of the same number, and it blocked the stable publication of the C-34 fix: 0.15.1 is already on the Marketplace as a pre-release, the Marketplace never accepts a number twice, and a 0.15.2 extension would have tried to fetch a CLI 0.15.2 that does not exist.
package.jsonnow declares the CLI version to fetch underspecterCli.default, beside the existingspecterCli.range. A test binds it to the repository'sVERSIONfile and to the range.specter.versionstill overrides it. The extension's own version is free to move without a CLI release.The two Makefile gates that paired the numbers move with it:
version-syncwritesVERSIONintospecterCli.defaultand leaves the extension version alone;release-checknames the VSIX afterpackage.json.publish-vscodenow reads the token fromVSCE_PATin the environment instead of aPAT=argument on the command line.How it was built
9d8e940spec: spec-vscode 7.0.0, C-27 amended, AC-50 amended, AC-83 added. Major: reading the extension's own version no longer conforms.84db6aered tests: eight runtime assertions failing, reached throughrequire.privateVersionFor, the wrapper,package.json, the Makefile.Verification
tscclean,eslintzero errors, jest 358 of 358, extension builds.spec-watchtests fail on this machine because the user holds 124 of 128 inotify instances, and they fail identically on an untouched checkout ofmainthere. No Go file changes here. CI is the Go gate.Next
An extension-only bump to 0.15.2 and the stable Marketplace publish follow in a separate bump PR once this merges.
🤖 Generated with Claude Code
https://claude.ai/code/session_01J3X8T9AMWkTdq75Wi27Nfn