test(packaging): run the engine/corpus pairing scenarios under noscripts - #885
Merged
Merged
Conversation
CP bugs/OW-081, the #882 acceptance list. The container test switched its RPM transactions from tsflags=noscripts to scriptlets, which dropped the noscripts case instead of adding scriptlets beside it. A pass with scriptlets is not evidence that the refusals hold on dependency resolution alone. The container test takes a mode: scripts (the default, unchanged) or noscripts (RPM only). In noscripts mode every dnf transaction carries --setopt=tsflags=noscripts and every rpm -U and rpm -Uvh carries --noscripts. All scenarios and both separate checks, package-manager state and corpus digest, run as before. The scriptlet check is inverted: it asserts no identity keys were provisioned, which proves the mode took effect. package-smoke gains a third job, "kensa-rules compat rockylinux:9 noscripts"; the two existing job names are unchanged. Local run against main's packages from ab68f30 and the v0.7.1 GA: noscripts 39 of 39, scripts 39 of 39, the only difference the inverted scriptlet check. A copy with the noscripts flags removed failed on that check alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes the open
tsflags=noscriptsitem on the #882 acceptance list (CPbugs/OW-081). #882 switched the RPM container transactions from noscripts to scriptlets. That removed the noscripts case instead of adding scriptlets beside it. A pass with scriptlets is not evidence for the noscripts case.kensa-rules-compat-container-test.shtakes a mode:scripts(default, unchanged) ornoscripts(RPM only).dnf installanddnf upgradecarries--setopt=tsflags=noscripts, and everyrpm -Uandrpm -Uvhcarries--noscripts.kensa-rules compat rockylinux:9 noscripts. The existingkensa-rules compat rockylinux:9andkensa-rules compat ubuntu:24.04names are unchanged.No package, spec or product code changes.
Evidence (local, before push)
Packages:
main's package-smoke artifact fromab68f303(run 36367957565) as new, and the published v0.7.1 RPMs as old, onrockylinux:9.identity keys exist, so a scriptlet ran despite noscriptsThe two passing runs differ only in the inverted scriptlet check.
Not covered
🤖 Generated with Claude Code