feat(asm): add PATCH and DELETE /tags/{tag_id} to complete the Tags resource#3
Open
dmchaledev wants to merge 1 commit into
Open
feat(asm): add PATCH and DELETE /tags/{tag_id} to complete the Tags resource#3dmchaledev wants to merge 1 commit into
dmchaledev wants to merge 1 commit into
Conversation
Tags could be created and listed but never renamed, recolored, or deleted. Adds updateTag and deleteTag operations, a reusable TagId path parameter, and description fields on listTags and createTag. https://claude.ai/code/session_01J5oRgC1dr2enDMdNx8WxhD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Tags resource was missing two of the four CRUD operations. Users could create and list tags, but there was no way to rename a tag, change its color, or delete it — making tag management effectively read-only after initial creation.
Changes
PATCH /tags/{tag_id}(updateTag) — update a tag'snameand/orcolor; returns the updatedTagobjectDELETE /tags/{tag_id}(deleteTag) — permanently removes the tag and strips it from all assets it was applied to; returns204 No Contentcomponents/parameters/TagId— reusable path parameter (mirrors the existingAssetIdpattern)descriptionfields tolistTagsandcreateTag(were previously empty, which triggers Spectral warnings)Why this is high-leverage
Tags are used to organize and filter assets across the entire ASM inventory. Without update/delete, any typo or color change requires deleting and re-creating the tag at the application level, and stale tags accumulate with no removal path via the API.
Test plan
asm/openapi.yamlPATCH /tags/{tag_id}response schema matchesTagcomponentDELETE /tags/{tag_id}returns 204 with no bodyTagIdpattern (^tag_[a-z0-9]{16}$) matches the example inTagschema (tag_0001aabbccdd0001)https://claude.ai/code/session_01J5oRgC1dr2enDMdNx8WxhD
Generated by Claude Code