#115 fixed bookmark treeview, and more robust saving of user bookmarks#125
Merged
Conversation
…ds. Renamed commands and methods to be clear that they refer to user bookmarks.
korli
reviewed
May 21, 2026
korli
reviewed
May 21, 2026
Contributor
|
LGTM. Can this be merged or do you have something to add? |
Contributor
Author
|
It can be merged, and Issue #115 can be closed. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the bookmark treeview issue #115 . It was just trapped in an IF statement that it didn't need to be in.
Also made the saving of user bookmarks more robust. It will save the attributes when a user bookmark is added or deleted, instead of doing it on QuitReqested. That way if the app crashed you won't lose changes made to user bookmarks.