Avoid startup stall with non-fatal startup preflight and cached betterdisplaycli resolution#3
Merged
Merged
Conversation
Closed
Copilot
AI
changed the title
[WIP] Fix issue with launching process not reaching log line
Avoid startup stall by deferring May 29, 2026
betterdisplaycli resolution and hardening path lookup
Owner
|
@copilot LGTM but can you remove the tests and i'll test it when im home? |
Contributor
Author
Done in |
Hacksore
requested changes
May 30, 2026
Copilot
AI
changed the title
Avoid startup stall by deferring
Avoid startup stall with non-fatal startup preflight and cached May 30, 2026
betterdisplaycli resolution and hardening path lookupbetterdisplaycli resolution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daemon could appear stuck during launch before reaching early startup logs, with suspicion around
get_betterdisplay_path()resolution. This change keeps startup resilient while making path discovery deterministic and efficient.Startup flow
betterdisplayclipreflight duringApp::initialize().Path resolution behavior
get_betterdisplay_path()to returnanyhow::Result<PathBuf>instead of terminating the process.BETTERDISPLAYCLI_PATHis set but invalid, return a descriptive error./opt/homebrew/bin,/usr/local/bin,/usr/bin,/bin) and removed PATH scanning from this flow.