Skip to content

fix: removed hero waiting from page and into judge hero #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michelleyeoh merged 1 commit into from
May 11, 2026
Merged

fix: removed hero waiting from page and into judge hero #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions app/(pages)/(hackers)/(hub)/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ import HeroJudging from '../_components/HomeJudging/HeroJudging';
import HackerChoiceAward from '../_components/HomeJudging/HackersChoiceAwards';
import HeroHacking from '../_components/HomeHacking/HeroHacking';
import { useRollout } from '@pages/_hooks/useRollout';
import HeroWaiting from '../_components/HomeJudging/HeroWaiting';

export default function Page() {
const { rolloutRes, loading } = useRollout('hacking-starts');
Expand All @@ -32,7 +31,6 @@ export default function Page() {
</ClientTimeProtectedDisplay>
{/* temporarilty set featureId below to "hero-hacking" to test */}
<ClientTimeProtectedDisplay featureId="hero-judging">
<HeroWaiting />
<HeroJudging />
<HackerChoiceAward />
</ClientTimeProtectedDisplay>
Expand Down
8 changes: 4 additions & 4 deletions app/(pages)/(hackers)/_components/HomeJudging/HeroJudging.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { LuEye, LuEyeOff } from 'react-icons/lu';

import useTableNumberContext from '@pages/_hooks/useTableNumberContext';
import JudgeBanners from './_components/JudgeBanners';
// import HeroWaiting from './HeroWaiting';
import HeroWaiting from './HeroWaiting';
import DoneJudgingModal from './_components/DoneJudgingModal';

import clouds from '@public/hackers/hero/Clouds.svg';
Expand All @@ -25,9 +25,9 @@ export default function HeroJudging() {
}
}, [hasDismissedModal]);

// if (!tableNumber) {
// return <HeroWaiting />;
// }
if (!tableNumber) {
return <HeroWaiting />;
}

return (
<div className="w-full h-screen p-4 md:p-10">
Expand Down
Loading