fix: handle LSP server requests and workspace initialization#1
Open
diopolgg wants to merge 1 commit into
Open
Conversation
Fix three issues in the LSP client that caused unreliable startup: - Use explicit UTF-8 encoding without BOM on the LSP process stdin. StreamWriter.BaseStream was writing a 3-byte BOM preamble before Content-Length headers, corrupting the JSON-RPC framing. - Handle server-to-client requests (e.g. workspace/configuration) by sending proper responses. Previously these were silently ignored, causing the server to stall waiting for a reply. - Wait for the workspace $/progress end notification before declaring the client initialized, so tools don't run against a partially loaded workspace. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
UTF8Encoding(false)for the LSP process stdin to prevent a 3-byte BOM preamble from corrupting Content-Length headersworkspace/configurationinstead of silently ignoring them, which caused the server to stall$/progressend notifications before declaring the client initialized, ensuring tools don't run against a partially loaded workspaceTest plan
dotnet build)csharp_set_workspacecompletes without timeout🤖 Generated with Claude Code