Find unpublished Nightly drafts before publication - #121
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe release flow now retrieves candidate metadata through ChangesRelease candidate validation
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to Nightly publication can now locate unpublished draft releases through the GitHub CLI while rejecting invalid release metadata. Existing publication guards remain in place, and no concrete merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Nightly publication stops after successful signed staging because GitHub's release-by-tag REST endpoint does not return the unpublished draft. The 1.4.0 draft and signed archive remain intact.
Use the draft-aware
gh release viewlookup before publication and reject a changed or incomplete release identity. Existing Stable releases still stop at the existing guard. Public candidate verification and Stable isolation remain unchanged.Validation: seven regression cases passed, including draft, prerelease, Stable, invalid identity, and lookup failure. The corrected lookup also read the real 1.4.0 draft without changing it. Full
pnpm checkandpnpm deploy:dry-runpassed.Recovery preserves the 1.4.0 archive from source
9e1aedccd357875dd1fca56dadb81e27819b6fe0, SHA-2564495abaa496e7aee0f006cc63a25a9eb2493e27d2388ac165819ec49a7375673. Its signature and bytes were independently verified. Signing and all staging/cleanup checks passed in https://github.com/HQBase/hqbase/actions/runs/34058089481; only publication needs to resume.Summary by CodeRabbit
Bug Fixes
Tests