Fix native client OAuth lifetime and Mail API gaps - #117
Merged
Conversation
bermanto
had a problem deploying
to
hqbase-staging
September 5, 2026 17:32 — with
GitHub Actions
Failure
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
bermanto
had a problem deploying
to
hqbase-staging
September 5, 2026 17:38 — with
GitHub Actions
Failure
bermanto
marked this pull request as ready for review
September 5, 2026 19:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Offline OAuth clients lose access when the approving browser session expires, and the draft response schema conflicts with its signature snapshot. Fix both defects, add signature management under a separate
signatures:managepermission, and let v1 clients request label membership withincludeLabels=true.DraftFields, write-time signature selection, and saved signature snapshots in both OpenAPI documents.Fixes #112, #113, #114, and #115.
This PR builds on #116 and targets
fix/audit-reliability. Review that PR first, then retarget this PR to main after it merges. Canonical documentation: HQBase/hqbase-site#50.Validation:
pnpm checkpassed (887 unit tests and 222 Worker integration tests; 2 unit tests skipped).pnpm deploy:dry-runpassed. The sitepnpm checkpassed. A deployed native-client regression test covers signature CRUD, decoding a saved draft after signature deletion, v1 label opt-in, refresh after web sign-out, and connection revocation. Linux and Windows CI passed on commit885433d48db103310f4da6f2f0b14fd874f9a7e6. Staging E2E passed on the same commit, including the deployed native-client test, resource recovery, populated upgrade, hostname move/restore, backup/restore, and cleanup.