Skip to content

Reset staging sign-in counters between release phases - #111

Merged
bermanto merged 1 commit into
mainfrom
agent/1.3.4-staging-session
Sep 1, 2026
Merged

Reset staging sign-in counters between release phases#111
bermanto merged 1 commit into
mainfrom
agent/1.3.4-staging-session

Conversation

@bermanto

@bermanto bermanto commented Sep 1, 2026

Copy link
Copy Markdown
Member

The 1.3.4 release gate completed the real 1.3.3 to 1.3.4 repair, then hit the production sign-in limit on its eleventh staged login in one 15-minute window.

This change clears only auth.email and auth.ip rate-limit rows in the disposable release-gate D1 database after the repair checks and before the final lifecycle suite. It does not change the production limit or customer data.

Checks:

  • pnpm check
  • pnpm deploy:dry-run
  • focused staging-workflow test
  • independent review

Summary by CodeRabbit

  • Bug Fixes
    • Improved staging lifecycle validation by clearing temporary authentication rate limits before final end-to-end checks.
    • Ensured disposable sign-in probes are reset after binding checks, preventing stale authentication state from affecting test results.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: b20ab085-4af8-412c-9aa1-14838b389423

📥 Commits

Reviewing files that changed from the base of the PR and between e5c0d11 and 9a7ab03.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • test/unit/scripts/staging-workflow.test.mjs

Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review.


📝 Walkthrough

Walkthrough

Changes

Staging lifecycle verification

Layer / File(s) Summary
Reset sign-in probe rate limits
.github/workflows/release.yml, test/unit/scripts/staging-workflow.test.mjs
The staging workflow deletes auth.email and auth.ip rate-limit records before final lifecycle verification. Tests verify the step and its position after binding checks.
Estimated code review effort: 1 (Trivial) ~5 minutes

Merge Risk: ⚪ Minimal · up to 9a7ab

This change resets only staging release-gate rate-limit records between workflow phases without changing production limits or customer data; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: resetting staging sign-in counters between release phases.
Description check ✅ Passed The description explains the failure, the scoped database cleanup, and the verification performed. It does not use the template headings exactly and does not include the requested checkbox format, but…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Description check

Explanation

The description explains the failure, the scoped database cleanup, and the verification performed. It does not use the template headings exactly and does not include the requested checkbox format, but the required information is mostly complete.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/1.3.4-staging-session

Comment @coderabbitai help to get the list of available commands.

@bermanto
bermanto merged commit 895757e into main Sep 1, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant