Repository navigation
feat(RELEASE-2A): independently witness installed OS and wheel dependency candidates - #72
Conversation
… wheel dependency identities Collect bounded source-bound candidate hashes from signed-snapshot OS inventory, installed Python inventory, resolved source lock and all 12 staged wheel bytes. Fail closed on malicious/symlinked/missing evidence; never promote or authorize release from a single observation.
…r independent OCI gate Invoke observer from exact-commit Git worktree after full offline image aggregate, retain only bounded hashes and counts, and extend stage source closure plus workflow regression guards.
…ndent lock freeze criteria Anchor next milestone to merged PR #71, actual 120/13 package observations and no-deployment authority boundaries, preserving historical roadmap rows.
…ribution versions Parse hash-verified wheel archive METADATA, require exact wheel filename/name/version identities and the complete installed venv set (twelve wheels plus pip). Reject extra staged files, links and directories instead of only counting .whl names. Preserve candidate-only release authority.
…e-set binding Use genuine synthetic wheel ZIP archives; reject forged METADATA, wrong installed versions, extra/missing Python distributions, non-wheel stage files, nested payloads and symlink substitutions.
…on closure Document wheel METADATA/filename/version equality, sole allowed pip exception and additional non-wheel rejection without relaxing release policy.
HMarcusWH
left a comment
There was a problem hiding this comment.
Independent code review — RELEASE-2A observer fixes
Reviewed source: 5af6b28dbf479fa4a926adf077413a9186041838.
I checked the source-bounded installed inventory parser, canonical wheel filename and ZIP .dist-info/METADATA decoder, duplicate distribution checks, per-wheel SHA256 attestation, exact staged-directory closure, installer-only pip exception, main policy source binding and new mutation tests. The original two P2 evidence gaps are source-repaired.
Real positive: RELEASE-1 run 39162932833 passed 201/201 fast contracts, scanner-compatibility and full installed-image OCI/recovery qualification. Its actual dependency observation reports 12 wheel versions exactly matched to installed packages, no unlisted wheelhouse content and one permitted venv-provided pip distribution.
Still no lock approval: This establishes one build's dependency integrity, not independently repeated exact-source/toolchain reproducibility. requirements.lock is generated dynamically, the initial CA bootstrap is not version-frozen, and corresponding-source/licensing, host, network and publication gates remain false.
Merge gate at review time: LOCAL-1 full-game campaign was still running. This COMMENT review is not final merge approval; retain the draft until all triggered workflows complete successfully and review remains current.
HMarcusWH
left a comment
There was a problem hiding this comment.
Final boarding — RELEASE-2A exact-head source/CI review
Reviewed 5af6b28dbf479fa4a926adf077413a9186041838 following the prior manual source review. All 5/5 workflows have completed successfully, including 201/201 release contracts, source-pinned Syft scanner, real full OCI and packaged smoke, local full-game qualification, baseline, merge gate, and publication-prohibition gate. No failed required job.
The real installed-image observation at run 39162932833 verifies installed_wheel_versions_verified=true, wheelhouse_closed=true, candidate_integrity_observed=true, 120 native packages, 13 installed Python distributions, and 12 attested wheel archives (plus the explicit venv-provided pip exception). Confirmed the observer remains a measurement-only source-attested verifier.
Decision: approved for CODE MERGE only at this exact SHA. Neither the observer nor merging it grants dependency-lock approval, reproducibility across independent exact-source builds, license compliance, artifact distribution, production host, public bot or live transport. offline_candidate_qualified=false and release_blocked=true remain binding.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
The account paying for this security review has reached its Codex usage limits. The payer can check the Codex usage dashboard. For personal accounts, using credits requires enabling “Use credits for security reviews” in Code review settings. If you do not manage the paying account, contact this repository's admins. |
…-2A mainline Preserve PR #72's independent installed wheel/version observer intact. Apply only the five source-status and always-present merge-gate paths on the new base. Do not change OS/wheel lock approval, license/publication/network/deployment/strength authority.
…status Verified exact-head 8/8 CI green including full OCI/SQLite/recovery, LOCAL-1, source-status contract and current b4/J3/runtime invariants. Preserves all PR #72 dependency observer code. Does not authorize distribution, license, dependency lock, host, network or public bot deployment.
Manual review corrections: installed distributions and wheelhouse closure
Exact head:
5af6b28dbf479fa4a926adf077413a9186041838. The deep repository audit identified two P2 evidence gaps in the initial observer. Both are now source-repaired and covered by destructive tests:.dist-info/METADATAand canonical filenames; venv-providedpipis the only permitted nonwheel distribution, still recorded but not independently approved.runtime-wheels.lockandwheel-attestation.json; extra.pth,.py, other files, directories, or symlinks fail.Exact-head evidence: 201/201 RELEASE-1 unit/negative tests passed, scanner compatibility passed, and full real-image RELEASE-1 OCI integration passed at run 39162932833. The actual installed-image dependency report confirms
installed_wheel_versions_verified=true,wheelhouse_closed=true,wheel_count=12, andinstaller_distribution_exceptions=1(pip). LOCAL-1 and remaining workflow checks are verified separately; real-image green is not lock or distribution approval.No authority upgrade: source-lock resolution and bootstrap CA version are not yet independently frozen;
dependency_lock_approved=false,offline_candidate_qualified=false,public_bot_release=false, andartifact_distribution_authorized=false. Keep this PR draft until the full real-image verification and final review pass.RELEASE-2A — candidate-only dependency inventory observation
Base
main:952a2c5cddff842efc5418f21e5987f51bcad6bf(merged PR #71).Exact PR head:
d781de2753a1710c1da81f1458a7ce097ea51cd7.Draft / DO NOT MERGE until exact-head CI and review.
Objective
RELEASE-1 now independently validates an installed, offline-only three-engine OCI image, real SLSA/SPDX and packaged smoke/recovery evidence. Its remaining mechanical gates include
os_lockandwheel_lock. This PR does not freeze those locks. It adds the missing source-bound observation of the exact installed Ubuntu and Python inventories and all 12 staged wheel binaries so independent repeated builds can be compared before a separate, reviewed lock-freeze PR.Changes
scripts/observe-release-dependencies.py: bounded, canonical sorted OSdpkg-queryrecords, installedpip freeze --allidentities, actual wheel-by-wheel SHA256 and source/runtime lock reconciliation against the staged manifest and source attestation.docs/RELEASE_2A_DEPENDENCY_OBSERVATION.mdand ROADMAP.The historical green PR #71 run recorded 120 installed Ubuntu packages and 13 Python distributions; these are observations, not pre-approved pins. Acceptance of this PR means the observer operates correctly on fresh CI images, not that two separate builds are reproducible.
Non-grants
Signed APT snapshot/base identity, controller/source licensing, publisher signature, destination host, live transport and operator approval remain independent and explicitly unqualified.
Required verification
Next after this PR: independently compare repeated exact-source build observations and propose reviewed OS/wheel pins, without granting public release.