Repository navigation
feat(ONLINE-3B): qualify pinned Lichess bridge against offline full-game simulator - #66
Conversation
…idge against sealed UCI
…whole-container games
…networkless test image
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5dd1acdf42
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if cmd("git", "status", "--porcelain", "--untracked-files=no", cwd=location): | ||
| raise ValueError("pinned bridge checkout has modified tracked files") |
There was a problem hiding this comment.
Reject untracked files in the pinned checkout
When build/vendor/lichess-bot already exists, this verification explicitly ignores untracked files, but run_offline.py later copies the entire checkout (apart from .git and bytecode) and executes it. A stale or injected untracked module such as requests.py, sitecustomize.py, or a file under lib/ can therefore alter the bridge while the checkout is reported as the pinned revision. Check for untracked files as well, or construct the execution tree exclusively from tracked Git content.
Useful? React with 👍 / 👎.
ONLINE-3B — Draft, offline only
Implements the verified single-PR architecture: pinned upstream lichess-bot, fail-closed effective configuration, local streamed API with independent chess legality, real sealed Allfather UCI, complete-game tests and independent evidence validation.
No live Lichess credentials, account upgrade, internet play, strength claims, or deployment authorization. Exact-head CI and both-color natural game qualification are required before review/merge.
Implementation is in progress. This PR must remain draft until the end-to-end and negative controls are green.