Skip to content

feat(ONLINE-3B): qualify pinned Lichess bridge against offline full-game simulator - #66

Merged
HMarcusWH merged 16 commits into
mainfrom
feat/online-3b-offline-bridge-qualification
Oct 11, 2026
Merged

HMarcusWH merged 16 commits into
mainfrom
feat/online-3b-offline-bridge-qualification

Conversation

@HMarcusWH

Copy link
Copy Markdown
Owner

ONLINE-3B — Draft, offline only

Implements the verified single-PR architecture: pinned upstream lichess-bot, fail-closed effective configuration, local streamed API with independent chess legality, real sealed Allfather UCI, complete-game tests and independent evidence validation.

No live Lichess credentials, account upgrade, internet play, strength claims, or deployment authorization. Exact-head CI and both-color natural game qualification are required before review/merge.

Implementation is in progress. This PR must remain draft until the end-to-end and negative controls are green.

@HMarcusWH
HMarcusWH marked this pull request as ready for review October 11, 2026 19:07
@HMarcusWH
HMarcusWH merged commit 60e4801 into main Oct 11, 2026
40 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-11T19:12:10.189193Z 5dd1acd Draft marked ready
🔒 Security Review ✅ Completed 2026-10-11T19:11:01.837683Z 5dd1acd Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5dd1acdf42

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +25 to +26
if cmd("git", "status", "--porcelain", "--untracked-files=no", cwd=location):
raise ValueError("pinned bridge checkout has modified tracked files")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Reject untracked files in the pinned checkout

When build/vendor/lichess-bot already exists, this verification explicitly ignores untracked files, but run_offline.py later copies the entire checkout (apart from .git and bytecode) and executes it. A stale or injected untracked module such as requests.py, sitecustomize.py, or a file under lib/ can therefore alter the bridge while the checkout is reported as the pinned revision. Check for untracked files as well, or construct the execution tree exclusively from tracked Git content.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant