Conversation
There was a problem hiding this comment.
Pull request overview
This PR bumps rubato to v2.0.0, updates core dependencies to audioadapter/audioadapter-buffers 3.x, and adjusts tests accordingly while also expanding async resampler test coverage.
Changes:
- Bump crate version to 2.0.0, raise MSRV to Rust 1.85, and update dependency versions (notably
audioadapterandaudioadapter-buffersto 3.0). - Simplify random test data generation by switching from
thread_rng()/Rngtorand::random()in multiple test modules. - Add new async tests validating that
set_resample_ratio_relative()affects produced/consumed frame ratios as expected.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/synchro.rs | Removes unused rand::Rng import in tests. |
| src/sinc_interpolator/sinc_interpolator_sse.rs | Updates tests to use rand::random() instead of thread_rng() + Rng. |
| src/sinc_interpolator/sinc_interpolator_neon.rs | Updates tests to use rand::random() instead of thread_rng() + Rng. |
| src/sinc_interpolator/sinc_interpolator_avx.rs | Updates tests to use rand::random() instead of thread_rng() + Rng. |
| src/sinc_interpolator/mod.rs | Updates scalar interpolator tests to use rand::random() and removes Rng import. |
| src/lib.rs | Re-exports audioadapter_buffers and updates test input generation to rand::random(). |
| src/asynchro.rs | Removes rand::Rng import and adds new tests/helpers for relative ratio frame-count behavior. |
| README.md | Updates MSRV statement and adds v2.0.0 changelog entry. |
| Cargo.toml | Bumps crate version/MSRV and updates dependency versions (including dev-deps). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.