-
Notifications
You must be signed in to change notification settings - Fork 0
fix: resetAccount recifra feedback com a DEK nova em vez de descartá-la (closes #121) #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Guiroos
wants to merge
4
commits into
main
Choose a base branch
from
claude/quirky-johnson-czr4gt
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
4cac97a
fix: resetAccount recifra feedback com a DEK nova em vez de descartá-…
claude 1b814ce
fix: cobre getAllFeedbacks e blinda decryptDek contra DEK antiga ileg…
claude 31f3019
fix: fecha os dois nits da 2ª rodada de revisão de #136
claude 2fed7d2
fix: sentinela de getAllFeedbacks não afirma causa que não conhece; t…
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| import { describe, it, expect, beforeAll } from 'vitest' | ||
| import { randomBytes } from 'crypto' | ||
| import * as schema from '@/lib/db/schema' | ||
| import { neonTestingSetup } from './setup' | ||
| import { createTestDb, type TestDb } from './helpers/db' | ||
| import { createUser } from './helpers/factories' | ||
|
|
||
| neonTestingSetup() | ||
|
|
||
| let db: TestDb | ||
| let userId: string | ||
|
|
||
| beforeAll(async () => { | ||
| db = createTestDb() | ||
| ;({ id: userId } = await createUser(db, `admin-feedback-${Date.now()}`)) | ||
| }) | ||
|
|
||
| describe('getAllFeedbacks', () => { | ||
| it('não derruba a lista quando uma linha está órfã (cifrada com outra DEK)', async () => { | ||
| const { encryptField } = await import('@/lib/crypto/fields') | ||
| const { getAllFeedbacks } = await import('@/lib/queries/admin') | ||
|
|
||
| // Simula uma linha cifrada com uma DEK que não é a do usuário — mesmo estado de uma | ||
| // linha órfã de um reset de conta cuja DEK antiga foi destruída. | ||
| const [orfa] = await db | ||
| .insert(schema.feedback) | ||
| .values({ | ||
| userId, | ||
| category: 'outros', | ||
| page: '/dashboard', | ||
| message: encryptField('cifrado com DEK destruída', randomBytes(32)), | ||
| }) | ||
| .returning({ id: schema.feedback.id }) | ||
|
|
||
| const todos = await getAllFeedbacks() | ||
|
|
||
| expect(todos.find((f) => f.id === orfa!.id)?.message).toBe('[mensagem ilegível]') | ||
| }) | ||
|
|
||
| it('não derruba a lista quando a DEK do usuário está ilegível', async () => { | ||
| const { getAllFeedbacks } = await import('@/lib/queries/admin') | ||
|
|
||
| const [outro] = await db | ||
| .insert(schema.users) | ||
| .values({ email: `dek-ilegivel-${Date.now()}@t.com` }) | ||
| .returning({ id: schema.users.id }) | ||
|
|
||
| // 'enc:' + bytes aleatórios: passa o guard de prefixo e falha no auth tag do GCM, | ||
| // que é o estado de uma DEK cifrada com uma MEK que não é mais a do ambiente. | ||
| await db.insert(schema.userSettings).values({ | ||
| userId: outro!.id, | ||
| encryptedDek: 'enc:' + randomBytes(60).toString('base64'), | ||
| creditMode: 'accrual', | ||
| faturaActiveFrom: null, | ||
| }) | ||
| const [linha] = await db | ||
| .insert(schema.feedback) | ||
| .values({ userId: outro!.id, category: 'outros', page: '/x', message: 'qualquer' }) | ||
| .returning({ id: schema.feedback.id }) | ||
|
|
||
| const todos = await getAllFeedbacks() | ||
|
|
||
| expect(todos.find((f) => f.id === linha!.id)?.message).toBe('[mensagem ilegível]') | ||
| }) | ||
| }) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.