Skip to content

feat: 설정 및 내 계정 페이지에 대한 디자인 시스템 적용#187

Merged
MTtankkeo merged 2 commits into
mainfrom
setting
Jul 15, 2026
Merged

feat: 설정 및 내 계정 페이지에 대한 디자인 시스템 적용#187
MTtankkeo merged 2 commits into
mainfrom
setting

Conversation

@MTtankkeo

Copy link
Copy Markdown
Member

작업 내용

  • 설정 화면 전반에 GDS 디자인 시스템 컴포넌트 적용
  • 설정 메뉴를 내 계정, 화면 테마, 알림, 이용 안내, 문의하기 항목으로 재구성
  • 모바일에서는 페이지 이동, 데스크톱에서는 사이드바 기반으로 동작하도록 반응형 레이아웃 적용
  • 닉네임 및 프로필 URL을 설정 화면에서 수정할 수 있도록 전용 화면과 입력 검증·저장 상태 추가
  • 시스템 설정, 밝은 모드, 어두운 모드를 선택하고 저장할 수 있는 테마 설정 기능 추가

추가 내용

  • 프로필 수정 성공 시 사용자 정보를 새로 불러오고, 저장 중 로딩 상태가 표시되도록 개선

피그마 참고:

모바일: https://www.figma.com/design/BA5LeHKF3saevi3poE85n2/Grimity_APP?node-id=1034-88437&m=dev
테블릿: https://www.figma.com/design/BA5LeHKF3saevi3poE85n2/Grimity_APP?node-id=1029-74189&m=dev

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new settings management system and refactors the settings UI into a responsive layout with dedicated sub-views (Account, Theme, Notifications, Contact, Nickname, and Profile URL) using GDS components. Key feedback includes using Flutter's native themeMode to properly handle system theme changes, simplifying the ThemeType enum, initializing text controllers with existing values in edit views, avoiding redundant ref.read calls within the notifier itself, adding a subText for the profile URL, and disposing of the ValueNotifier in SettingViewState to prevent memory leaks.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/presentation/app.dart Outdated
Comment thread lib/app/enum/theme_type.enum.dart Outdated
Comment thread lib/presentation/setting/view/setting_nickname_view.dart
Comment thread lib/presentation/setting/view/setting_profile_url_view.dart
Comment thread lib/presentation/common/provider/user_auth_provider.dart Outdated
Comment thread lib/presentation/setting/view/setting_account_view.dart
Comment thread lib/presentation/setting/setting_view.dart
@MTtankkeo
MTtankkeo merged commit 466731a into main Jul 15, 2026
1 check passed
@MTtankkeo
MTtankkeo deleted the setting branch July 15, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant