Skip to content

feat: 회원가입 페이지에 대한 디자인 시스템 적용#186

Merged
MTtankkeo merged 2 commits into
mainfrom
sign_up
Jul 12, 2026
Merged

feat: 회원가입 페이지에 대한 디자인 시스템 적용#186
MTtankkeo merged 2 commits into
mainfrom
sign_up

Conversation

@MTtankkeo

@MTtankkeo MTtankkeo commented Jul 12, 2026

Copy link
Copy Markdown
Member

작업 내용

  • 회원가입 화면 전반에 GDS 디자인 시스템 컴포넌트를 적용
  • 닉네임 입력, 약관 동의, URL 입력 단계를 PageView 기반 흐름으로 정리
  • 기존 개별 버튼들을 하단 공통 CTA(SignUpButton)로 통합
  • 회원가입 완료 후 환영(Welcome) 화면을 추가하고, 시작하기 버튼으로 홈 화면에 진입하도록 변경
  • 닉네임/URL 검증 성공 상태를 입력 필드에 표시
  • 회원가입 성공 시 UserAuthProvider의 사용자 정보를 갱신하도록 반영

피그마 참고:

모바일: https://www.figma.com/design/BA5LeHKF3saevi3poE85n2/Grimity_APP?node-id=1034-84144&m=dev
테블릿: https://www.figma.com/design/BA5LeHKF3saevi3poE85n2/Grimity_APP?node-id=1001-268806&m=dev

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the sign-up flow to integrate the new Design System (gds), introducing a welcome state and replacing old custom widgets with GDS components. The navigation is updated to use a PageView with a PageController, and the sign-up state management has been streamlined. The review feedback highlights a bug where error: true is hardcoded in SignUpNicknameTextField, and suggests optimizing SignUpButton by removing redundant ref.watch calls and simplifying the widget tree by passing onPressed directly to the button.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lib/presentation/sign_up/widget/sign_up_nickname_text_field.dart Outdated
Comment thread lib/presentation/sign_up/widget/sign_up_button.dart
@MTtankkeo
MTtankkeo merged commit 8da5db5 into main Jul 12, 2026
1 check passed
@MTtankkeo
MTtankkeo deleted the sign_up branch July 15, 2026 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant