fix: re-escape backslashes and quotes in Display/prettify output#146
Open
harry671003 wants to merge 1 commit into
Open
fix: re-escape backslashes and quotes in Display/prettify output#146harry671003 wants to merge 1 commit into
harry671003 wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 98.54% 98.55% +0.01%
==========================================
Files 15 15
Lines 6959 7013 +54
==========================================
+ Hits 6858 6912 +54
Misses 101 101 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
@codex review |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
evenyag
reviewed
May 26, 2026
Contributor
evenyag
left a comment
evenyag
left a comment
There was a problem hiding this comment.
Thank you. LGTM on the core fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Display impls for Matcher and StringLiteral wrote parsed string values directly into double-quoted PromQL output without re-escaping. This meant backslash escape sequences were lost during serialization:
Input:
{service=~"flagd\\.evaluation"}Prettified:
{service=~"flagd\.evaluation"}