feat: ESPI 4.0 Schema Compliance - Phase 15: BatchList #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements ESPI 4.0 schema compliance for BatchList entity, migrating from UUID to Long ID with auto-increment and completing the DTO/Mapper implementation for XML marshalling. Key Changes: - Changed BatchListEntity primary key from UUID to Long with IDENTITY generation - Moved batch_lists table to vendor-specific V2 migrations: - H2/MySQL: BIGINT AUTO_INCREMENT PRIMARY KEY - PostgreSQL: BIGSERIAL PRIMARY KEY - Created BatchListDto with JAXB annotations per espi.xsd BatchListType - Created BatchListMapper for Entity-to-DTO conversion (output-only) - Updated BatchListRepository for Long ID type parameter - Created comprehensive test suites: - BatchListDtoTest (16 tests) - BatchListMapperTest (11 tests) - Updated BatchListRepositoryTest for Long ID Technical Details: - BatchList is a simple operational entity (NOT an ESPI resource) - Does NOT extend IdentifiedObject per ESPI 4.0 specification - DTO uses defensive copy pattern to prevent external modification - Mapper follows Phase 14 pattern with @component annotation - All 582 tests passing (including integration tests) Resolves: Issue #28 - Phase 15: BatchList Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements ESPI 4.0 schema compliance for BatchList entity, completing Phase 15 of the migration plan.
Key changes:
Technical Details
Database Migrations
Vendor-specific table creation:
BIGINT AUTO_INCREMENT PRIMARY KEYBIGSERIAL PRIMARY KEYTest Results
Related
🤖 Generated with Claude Code