throttle-upon-activation-fix -> master#279
Open
rys4590 wants to merge 26 commits into
Open
Conversation
…ed, i hate me lyf
DANNA2828
reviewed
Jul 1, 2026
DANNA2828
reviewed
Jul 1, 2026
hillelv
previously approved these changes
Jul 1, 2026
hillelv
previously approved these changes
Jul 1, 2026
DANNA2828
reviewed
Jul 1, 2026
hillelv
reviewed
Jul 4, 2026
| this.logPath = logPathPrefix + "/" + name; | ||
|
|
||
| this.robotRelativeCameraPose = robotRelativeCameraPose; | ||
| setRobotRelativeCameraPose(robotRelativeCameraPose); |
There was a problem hiding this comment.
Initialize the members in the constructor and add to the list to use the setters with their values
|
|
||
| private LimelightPipeline pipeline; | ||
|
|
||
| private final List<Consumer<Limelight>> pendingConnectedRequests; |
There was a problem hiding this comment.
I don't think there is a reason for it to be a Consumer of limelight instead of a Runnable
Author
There was a problem hiding this comment.
לפי הבנתי runnable ישמור לעשות את הפעולה הזאת ספציפית על מצלמה אחת ולא על כולם מישומה
סתם חיפשתי בגוגל אני מאוד לא הבנתי את מה שקראתי אז לא לסמוך על זה
There was a problem hiding this comment.
כאילו זה לא בעיה
תמיד את מכניסה את הקונסומר לאותה מצלמה שאת הולכת להשתמש בה, את לא משתמשת באותו הקונסומר למצלמות שונות
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.