Preserve host caller identity in Phenotype broker requests - #309
Open
davidwkr wants to merge 1 commit into
Open
Conversation
davidwkr
force-pushed
the
fix/providerinstaller-phenotype-caller
branch
from
September 6, 2026 02:40
68f4612 to
24010c8
Compare
davidwkr
marked this pull request as ready for review
September 6, 2026 03:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ProviderInstaller's fallback can supply a GmsCore package context to code running in a client app. In an Android 17 downstream ROM capture, Wallet fell back after
com.google.android.gms.providerinstaller.dynamitecould not load; ProviderInstaller's Phenotype registration then failed withSecurityException: Unknown calling package name 'com.google.android.gms'.This draft proposes correcting the client identity at the Phenotype service connection. For broker transaction 46 and service ID 51, the wrapper replaces a claimed GmsCore package with the host application's package. It checks the host context UID, excludes GmsCore and cross-user bindings, and requires the expected service action, package and Binder descriptor. Receiver-side UID/package validation is unchanged.
The Parcel helper retains callback Binder references, unknown fields and trailing data. Unsupported or malformed requests pass through unchanged. Existing Play Integrity connection handling takes precedence.
Evidence and validation
git diff --checkpasses. A reproducible test runner is included underlib/tests/providerinstaller.Remaining work / scope questions
Opening as a draft for design review before platform integration and end-to-end testing.