Skip to content

localRepository: fix relative paths #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
martinbonnin merged 1 commit into from
Dec 31, 2025
Merged

localRepository: fix relative paths #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nmcp-tasks/src/main/kotlin/nmcp/internal/task/nmcpPublishFileByFileToMavenLocal.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,5 +23,5 @@ internal fun nmcpPublishFileByFileToFileSystem(
logger.info("Nmcp: copying files to $m2AbsolutePath")

File(m2AbsolutePath).mkdirs()
publishFileByFile(FilesystemTransport(m2AbsolutePath), inputFiles, parallelism)
publishFileByFile(FilesystemTransport(m2AbsolutePath, logger), inputFiles, parallelism)
}
3 changes: 3 additions & 0 deletions nmcp-tasks/src/main/kotlin/nmcp/transport/transport.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,10 @@ fun Content.toRequestBody(): RequestBody {

internal class FilesystemTransport(
private val basePath: String,
private val logger: GLogger,
) : Transport {
override fun get(path: String): BufferedSource? {
logger.info("Nmcp: read '$path'")
val file = File(basePath).resolve(path)
if (!file.exists()) {
return null
Expand All @@ -176,6 +178,7 @@ internal class FilesystemTransport(
}

override fun put(path: String, body: Content) {
logger.info("Nmcp: write '$path'")
File(basePath).resolve(path).apply {
parentFile.mkdirs()
sink().buffer().use {
Expand Down
4 changes: 2 additions & 2 deletions nmcp/src/main/kotlin/nmcp/internal/DefaultNmcpAggregationExtension.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ internal abstract class DefaultNmcpAggregationExtension(private val project: Pro
project.registerNmcpPublishFileByFileToFileSystemTask(
taskName = "nmcpPublishAggregationTo${options.name.get().capitalizeFirstLetter()}Repository",
inputFiles = allFiles,
m2AbsolutePath = project.provider { File(options.path.get()).absolutePath },
m2AbsolutePath = project.provider { project.file(options.path.get()).absolutePath },
parallelism = project.provider { 1 },
)
}

@Deprecated("Use the settings plugin or a convention plugin instead")
override fun publishAllProjectsProbablyBreakingProjectIsolation() {
check(project === project.rootProject) {
Expand Down
Loading