Skip to content

Conversation

@sschuberth
Copy link
Contributor

Please have a look at the individual commit messages for the details.

@sschuberth sschuberth force-pushed the modernize-kotlin-dsl-readme branch from 9d9d328 to 2b414f1 Compare April 8, 2025 19:59
@martinbonnin
Copy link
Member

Thanks for opening this!

Unfortunately, I'm in the other team and I like the old boring verbose syntax better for multiple reasons, the main one being that I can copy paste into any context and it will work without any additional compiler plugin and/or dependency.

It's much more simple. It doesn't look like a DSL but I found out the hard way that Gradle build scripts are not really declarative given they are reliant on the order of different calls at the end of the day.

Maybe that will change with declarative Gradle and I'll happily provide support for that but until then, I prefer to keep it this way.

@sschuberth
Copy link
Contributor Author

sschuberth commented Apr 9, 2025

Unfortunately, I'm in the other team and I like the old boring verbose syntax better

That's sad to hear, esp. as I thought GradleUp would also be about spreading the word about Gradle best-practices and idiomatic use of Kotlin DSL, and to me best-practices is not to stick to outdated syntax, even if that would widen the range of supported Gradle versions.

Anyway, let me split out some of the (hopefully) uncontroversial commit to a new PR for your review.

@sschuberth
Copy link
Contributor Author

Anyway, let me split out some of the (hopefully) uncontroversial commit to a new PR for your review.

See #41.

@martinbonnin
Copy link
Member

Thanks for splitting up those commits, they are merged. As for the rest, I think it's good that we can have this conversation and I will keep it as is. If consensus emerges that everyone prefers the other syntax, I'll revisit! Thanks!

@sschuberth sschuberth deleted the modernize-kotlin-dsl-readme branch April 9, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants