Add interpolator field to TimeSeries#23
Conversation
|
Two questions
|
|
Right now, if you save the logs to HDF5 and then load them, the interpolator information is lost. I think we should add that. I did not opt to add that in this PR, but I would do that soon. The way I would do it is that I would serialize the whole interpolator and deserialize it on load. This is not flexible. To use the log in the future, you'd have to have the same interpolator defined. That's already true for a bunch of the types that are serialized though, so I'm not too worried about the portability of the interpolator. Would you want that as a feature of this PR, or is a follow-up PR a better place for that? |
|
All good, just wanted to make sure we didn't miss anything. |
We've talked about this, and here it is. It's very simple, and that's the goal. It also has a useful default. I tested that this powers our downstream packages with no changes.