Add ability to save a log to an HDF5#17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
save_log_to_hdf5to allow the user to save their BasicLog as an HDF5 file after simulation is over. The resulting HDF5 file is the same. If HDF5Vectors.copy_to_hdf5_vector is faster than filling in an HDF5Vector one piece at a time, then this ought to benefit from it. Regardless, the ability to save a log is desirable.I added a unit test to make sure the resulting files were the same for the control system demo.
This actually works without the corresponding PR for HDF5Vectors; that PR isn't required but just make things much faster for key cases.
I also tidied up some dead code/comments and added some docstrings along the way.