Further resolve already supported types#16
Merged
tuckermcclure merged 4 commits intoMay 12, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
PortableStructs.from_dictmore robust for generic tuples, dictionaries, tagged values, and structs without keyword constructors.Motivation
Some parsed YAML/JSON values arrive with only partial type information from the containing field, such as
Tuple,NamedTuple,AbstractDict, orDict. The previous generic loading paths either skipped recursive decoding in some cases, treated dictionary type tags inconsistently, or relied too heavily on keyword constructors.Changes
Tupleand genericNamedTuple.zip.type_keyentries before redispatching tagged dictionaries.DictDict{K,V}OrderedDictOrderedDict{K,V}AbstractDictAbstractDict{K,V}viaOrderedDictRationalandComplex.typetag from the roses fixture so it remains ordinary dictionary data.Tests
Added coverage for:
type_keyfilteringRationalandComplexloadingI manually tested that this works with some demanding downstream projects as well.