Repository navigation
Implement hooks and fix custom schemes - #2
Merged
Merged
Conversation
…ript Release now runs automatically in CI when a push to main bumps the Cargo.toml version, replacing the interactive scripts/release.sh. Also adds scripts/test-deploy.sh for installing/reverting a local dev build via Homebrew without touching the published tap. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Modern Homebrew rejects installing a bare formula file that isn't part of a tap, so test-deploy.sh now maintains a small local tap (gnomad-dev/local) and writes the formula there instead. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Homebrew's build sandbox PATH doesn't include a rustup-managed cargo, so cargo install was failing with "command not found" inside the sandboxed build step. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
cargo shells out to rustc by bare name; Homebrew's sandbox intercepts it via its own wrapper script which failed since rustc's directory wasn't on the restricted PATH. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
The externally-managed rustup cargo can't cleanly drive Homebrew's sandboxed cc/linker shim (missing default libs at link time). Homebrew's own "rust" formula is built to work inside that sandbox, so depend on it as a build dependency instead of threading through the host cargo. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
… test gnomad's CLI has no --version flag (only --help, --apply, --update-schemes, -v). Use --help for the formula's test block and print the resolved binary path instead of a fabricated version string. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Fixed issues with custom schemes not applying correctly. Added support for hooks on gnomad events.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for hooks in order to run shell commands after gnomad processing on certain events. Fixed issue where custom schemes were not applying correctly.