Skip to content
This repository was archived by the owner on Jan 6, 2023. It is now read-only.

Fix assert in model.py#5

Open
medvedev1088 wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
blockchain-etl:bug/assert_failes
Open

Fix assert in model.py#5
medvedev1088 wants to merge 1 commit into
GoogleCloudPlatform:masterfrom
blockchain-etl:bug/assert_failes

Conversation

@medvedev1088

@medvedev1088 medvedev1088 commented Jan 24, 2019

Copy link
Copy Markdown

Found this bug when testing on a small dataset it fails when the number of items in the dataset is 3, the number of users is 10, the user rated 2, and I try to get 2 recommendations.

The assert is supposed to check that the number of items in the dataset is greater than the number of requested recommendations plus the number of items a user already rated. The reason I changed row_factor with col_factor is col_factor.shape[0] is the number of items in the dataset.

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@medvedev1088

Copy link
Copy Markdown
Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants