Skip to content

Respect explicit Hub endpoint during sync preflight#130

Open
mfreeman451 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
mfreeman451:fix/hub-flag-endpoint-override
Open

Respect explicit Hub endpoint during sync preflight#130
mfreeman451 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
mfreeman451:fix/hub-flag-endpoint-override

Conversation

@mfreeman451
Copy link
Copy Markdown
Contributor

@mfreeman451 mfreeman451 commented Apr 10, 2026

Summary

  • honor an explicit --hub endpoint during sync preflight instead of falling back to settings
  • thread the selected endpoint through hub sync resolution
  • add focused regression coverage for endpoint override behavior

Testing

  • go test ./pkg/hubsync -run 'TestEnsureHubReady_(GlobalFallbackWithHubEnabled|EndpointOverrideBeatsSettings)$' -count=1
  • go test ./cmd -run 'Test.Flag.Hub.|TestGetHubEndpoint.' -count=1

mfreeman451
mfreeman451 commented Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@mfreeman451 mfreeman451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mfreeman451 mfreeman451 marked this pull request as ready for review April 10, 2026 17:46
@mfreeman451 mfreeman451 force-pushed the fix/hub-flag-endpoint-override branch from 75856d0 to efe389d Compare April 11, 2026 05:15
@mfreeman451 mfreeman451 force-pushed the fix/hub-flag-endpoint-override branch from efe389d to 5dc364f Compare April 11, 2026 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mfreeman451