Skip to content

Skip workspace bootstrap for global hub starts#129

Open
mfreeman451 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
mfreeman451:fix/global-hosted-workspace-collection
Open

Skip workspace bootstrap for global hub starts#129
mfreeman451 wants to merge 1 commit intoGoogleCloudPlatform:mainfrom
mfreeman451:fix/global-hosted-workspace-collection

Conversation

@mfreeman451
Copy link
Copy Markdown
Contributor

@mfreeman451 mfreeman451 commented Apr 10, 2026

Summary

  • avoid scanning the global .scion grove as local workspace input during hosted global starts
  • keep global hosted start environment gathering scoped to the intended inputs
  • add a regression test for the global grove path

Testing

  • go test ./cmd -run 'TestStartAgentViaHub_(EnvGatherFailureCleansUp|GlobalGroveSkipsWorkspaceBootstrap)$' -count=1

mfreeman451
mfreeman451 commented Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@mfreeman451 mfreeman451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mfreeman451 mfreeman451 marked this pull request as ready for review April 10, 2026 17:47
@mfreeman451 mfreeman451 force-pushed the fix/global-hosted-workspace-collection branch from 3cc0ec8 to 128be5f Compare April 11, 2026 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mfreeman451