Mark failed local agent launches as error#111
Merged
ptone merged 5 commits intoGoogleCloudPlatform:mainfrom Apr 11, 2026
Merged
Mark failed local agent launches as error#111ptone merged 5 commits intoGoogleCloudPlatform:mainfrom
ptone merged 5 commits intoGoogleCloudPlatform:mainfrom
Conversation
mfreeman451
force-pushed
the
fix/local-start-run-failure-state
branch
from
ac7a584 to
286fd84
Compare
mfreeman451
force-pushed
the
fix/local-start-run-failure-state
branch
from
0454b40 to
3373b75
Compare
Contributor
Author
|
Follow-up cleanup is in. Changes:
Current head: |
Reorder the format string so the sentence reads naturally: "failed to launch container in image <img>: tmux binary not found: <cause>" instead of embedding the sentinel error mid-clause.
scion-gteam bot
pushed a commit
to ptone/scion
that referenced
this pull request
Apr 12, 2026
* Mark failed local agent launches as error * Log local config update failures during failed local starts * Use typed tmux launch error on failed local starts * Check prompt and agent config writes during failed local starts * Fix awkward dual-%w error message in classifyLaunchRuntimeError Reorder the format string so the sentence reads naturally: "failed to launch container in image <img>: tmux binary not found: <cause>" instead of embedding the sentinel error mid-clause. --------- Co-authored-by: Preston Holmes <ptone@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
errorwhen the runtime launch fails afteragent-info.jsonhas already been writtencreatedagent in list/status outputProblem
The local
scion startpath provisions agent state before attempting the runtime launch. IfRuntime.Runthen fails, the provisionedagent-info.jsonstays increatedstate forever even though no container ever started. In practice that leaves stale phantom agents behind in list output after launch failures.Validation
go test ./pkg/agent -run 'TestStart_(ErrorPropagation_Tmux|ErrorPropagation_Tmux_Missing|RunFailureMarksAgentInfoError)$'