Skip to content

Skip metadata interception in non-root containers#110

Merged
ptone merged 3 commits intoGoogleCloudPlatform:mainfrom
mfreeman451:fix/nonroot-metadata-interception
Apr 11, 2026
Merged

Skip metadata interception in non-root containers#110
ptone merged 3 commits intoGoogleCloudPlatform:mainfrom
mfreeman451:fix/nonroot-metadata-interception

Conversation

@mfreeman451
Copy link
Copy Markdown
Contributor

Summary

  • skip metadata IP interception setup when sciontool is running as a non-root user
  • keep metadata serving behavior unchanged while avoiding misleading interception failures in restricted containers
  • add focused coverage for the interception decision helper

Problem

In non-root containers, sciontool cannot install the iptables-based metadata interception rules. The metadata env vars are still the primary mechanism there, so attempting interception just produces noisy, misleading warnings without helping agent behavior.

Validation

  • go test ./pkg/sciontool/metadata

Copy link
Copy Markdown
Contributor Author

@mfreeman451 mfreeman451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mfreeman451 mfreeman451 marked this pull request as ready for review April 9, 2026 21:53
@mfreeman451 mfreeman451 force-pushed the fix/nonroot-metadata-interception branch from c54ea37 to 2cd7be8 Compare April 11, 2026 05:15
Copy link
Copy Markdown
Contributor Author

@mfreeman451 mfreeman451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ptone ptone merged commit 1a2129f into GoogleCloudPlatform:main Apr 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants