Ga security policy v2 #16094
Open
Ga security policy v2 #16094
+1
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modular-magician
added
the
awaiting-approval
|
Hello! I am a robot. Tests will require approval from a repository maintainer to run. Googlers: For automatic test runs see go/terraform-auto-test-runs. @roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
…ompute_security_policy This change promotes the request_body_inspection_size field from Beta to GA in the google_compute_security_policy resource. The GA Compute API (v1) now supports this field with values: 8KB, 16KB, 32KB, 48KB, and 64KB for WAF request body inspection configuration. Changes: - Removed version guards from schema definition - Removed version guards from expand/flatten functions - Updated ForceSendFields to include field for all versions - Removed [Beta] marker from documentation - Enabled tests for GA provider ```release-note:enhancement compute: promoted `request_body_inspection_size` to GA in `google_compute_security_policy` ```
SCSAndre
force-pushed
the
ga-security-policy-v2
branch
from
4bf5ecb to
74aca0d
Compare
Contributor
|
Hi @roaks3, a client has asked about support related to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR promotes the
request_body_inspection_sizefield from Beta to GA in thegoogle_compute_security_policyresource.GA API Confirmation: The Compute v1 (GA) API already exposes
requestBodyInspectionSizeand supports values up to 64KB.Changes Made
1. Schema Definition
{{- if ne $.TargetVersionName "ga" }}) fromrequest_body_inspection_sizefield2. Expand/Flatten Functions
expandSecurityPolicyAdvancedOptionsConfigflattenSecurityPolicyAdvancedOptionsConfig3. ForceSendFields
advancedOptionsConfig.requestBodyInspectionSizefor all versions4. Documentation
[Beta]marker fromrequest_body_inspection_sizefield5. Tests
request_body_inspection_sizeTesting
The acceptance test
TestAccComputeSecurityPolicy_withAdvancedOptionsConfigincludes:request_body_inspection_size = "64KB"