docs(agy): correct the fake_home wording on the --add-dir fallback - #586
Merged
Conversation
"harness internals" was wrong: the binary, settings.json, mcp_config.json and session state all belong to agy, not to evalbench. The only file in fake_home that is not agy's is the ADC copy staged by agent_cli.py. The reason for the line is unchanged -- fake_home is agy's home directory rather than a scenario workspace -- but the previous wording invited the objection that we copy into it.
omkargaikwad23
requested review from
IsmailMehdi,
helloeve and
prernakakkar-google
as code owners
August 31, 2026 11:17
prernakakkar-google
approved these changes
Sep 1, 2026
Collaborator
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #585. The comment above the
cwdfallback in_run_agy_clicalled
fake_home"harness internals". It isn't ours — the binary, settings,MCP config and session state all belong to agy. Reworded to say that.
No behaviour change.
Test plan
pytest evalbench/test/agy_cli_test.py— 68 passed