move common logic to size-plugin-core#27
Open
kuldeepkeshwar wants to merge 32 commits intoGoogleChromeLabs:masterfrom
Open
move common logic to size-plugin-core#27kuldeepkeshwar wants to merge 32 commits intoGoogleChromeLabs:masterfrom
kuldeepkeshwar wants to merge 32 commits intoGoogleChromeLabs:masterfrom
Conversation
* mjs to js * updated package.json * fixed typo (,) * added publish-size * publish size for master branch * fixed typo * fixed payload for size api * size-store api configurable via env variable * avoid publishing in test environment * added todo * pushed filename to store * checked file before writing/reading * corrected file write condition * updated test * moved fs-extra to dependencies * added filename to diff payload * add publish flag * add writeFile option * js to mjs
Co-Authored-By: Jason Miller <developit@users.noreply.github.com>
kuldeepkeshwar
changed the title
This was referenced Sep 2, 2019
|
Thank you for adding compression(gzip/brotli) option!!! 🎉 🎉 🎉 |
jimblue
approved these changes
Sep 7, 2019
jimblue
approved these changes
Sep 7, 2019
jimblue
left a comment
jimblue
left a comment
There was a problem hiding this comment.
Sounds good to me to be release! Thank you
|
Just a friendly ping, what's happening here? |
Collaborator
|
@jimblue This one is taking a while because @kuldeepkeshwar and I have been discussing structural options. I think we landed on a monorepo setup, but I haven't had a chance to branch from this PR and Kuldeep's logic in. |
Contributor
Author
|
@developit I can open a pull request here with a monorepo setup 🙃. Packages:
|
|
are we going ahead for monorepo architecture? I want brotli support in this plugin but looks like it's blocked because of that decision |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change: