EditText -> TextView to fix spacing problem (addendum to #49) - updated for kotlin release#60
Open
arberg wants to merge 23 commits intoGoodieBag:masterfrom
Open
EditText -> TextView to fix spacing problem (addendum to #49) - updated for kotlin release#60arberg wants to merge 23 commits intoGoodieBag:masterfrom
arberg wants to merge 23 commits intoGoodieBag:masterfrom
Conversation
… openkeyboard and requestPinEntryFocus
…which cannot always be fixed by padding. Also editTexts capture clicks, which prevents focus by clicking inactive pin-views. Added setTextPadding for setting offset of text for adjustments for fonts.
…. Added autoAdjustToSquareFormat parameter: Keep view square
…hen set to 0dp (which is similar to how ConstraintLayout works)
…lView for smaller height test-phones.
…lastTagHavingValue usage was incorrectly migrated. Cleaned up that lastTagHavingValue. Also simplified and fixed behaviour on delete. Before some pinviews (numbers, passwords) required 2-3 del to start deleting. Now all pinviews behave identically, no more special for numbers and passwords. The rule is the last unfilled view always has focus, delete always deletes, but does not move focus if last pinview had data (similar to when entering data).
…th, so we can reduce textSize via that listener
arberg
changed the title
Bugfix earlier (to-kotlin?) code: Open-keyboard delayed on init, should only open if not disabled in XML settings.
# Conflicts: # pinview/src/main/java/com/goodiebag/pinview/Pinview.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This includes #49, so I suggest merging that first, though the order probably won't matter.
EditTexts have bottom-offset, doesn't work well in some situations (maybe when changing font, I don't remeber the issue I had, except I had to change to TextView to use the lib with my fonts).
Added setTextPadding for setting offset of text for adjustments for fonts.
Added autoAdjustWidth parameter: Auto adjust width to available width (shrink only)
Added autoAdjustToSquareFormat parameter: Keep view square