Skip to content

Typed variables in firebase.gd - #463

Open
4Shage wants to merge 1 commit into
GodotNuts:mainfrom
4Shage:main
Open

Typed variables in firebase.gd#463
4Shage wants to merge 1 commit into
GodotNuts:mainfrom
4Shage:main

Conversation

@4Shage

@4Shage 4Shage commented Mar 7, 2025

Copy link
Copy Markdown

Look at issue #462

@WolfgangSenff

Copy link
Copy Markdown
Collaborator

:= is automatically typed correctly. In addition to that, in the past, we've had issues with typing them that way. I think I'll pull this down and do some testing, but I'm pretty sure this isn't needed at all.

@4Shage

4Shage commented Mar 7, 2025

Copy link
Copy Markdown
Author

I just wanted for godot's auto completion to work (if possible and doesn't interfere with something).
image
But if it wouldn't be possible I try to find some bypass

@WolfgangSenff

Copy link
Copy Markdown
Collaborator

It sort of depends on if that's actually working for you with your changes. If it is and you're not seeing any problems, can I ask what version of Godot you're using specifically?

@4Shage

4Shage commented Mar 7, 2025

Copy link
Copy Markdown
Author

I use 4.4 mono

@WolfgangSenff

WolfgangSenff commented Apr 25, 2025

Copy link
Copy Markdown
Collaborator

I realized why the := is not working the way you'd expect, but I also have some other changes that need to go in. Do you mind if I end up making the PR to solve this, and then I'll include your changes and credit you with this change?

@4Shage

4Shage commented Apr 25, 2025

Copy link
Copy Markdown
Author

I don't mind :)

@WolfgangSenff

Copy link
Copy Markdown
Collaborator

Awesome! I'll close this when I'm able to get around to it today, and add you to the first-time contributors list for the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants