Repository navigation
Conversation
…ault the dashboard. Point Terms, Privacy, help, and install actions at the owned GitHub drafts and docs, swap web favicons and the empty-vault mark for the Komboe kit, and drop the in-vault onboarding rail so filters and items use the content area. Add a persistent Downloads item in the vault nav and on the marketing downloads page without claiming unpublished store binaries. Co-authored-by: Admin <GoDeskio@users.noreply.github.com>
…lly produced. The signed-in Downloads page and the marketing downloads section read komboe-downloads.json. The clients image generates that manifest after it builds the Chromium MV3 zip and copies the zip into the web vault with its sha256. Missing desktop, macOS, iOS, and production Android packages stay unavailable, and the debug APK is refused. QR codes are drawn locally from the install URL. Co-authored-by: Admin <GoDeskio@users.noreply.github.com>
…e vault. The marketing page no longer shows coming-soon download buttons. Each platform card states whether the shared manifest has a file. A link and a local QR code are emitted only for an absolute published URL. Co-authored-by: Admin <GoDeskio@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Signed-in vaults no longer show the upstream onboarding rail. Downloads is a persistent sidebar item, and the public marketing Downloads page is generated from the same release manifest. A link exists only when a build recorded a real file and its sha256. This branch does not deploy, change DNS, submit stores, or add signing credentials.
Commits:
ca69ab1a(branding and vault layout),69d8236d(downloads manifest),71c4b843(marketing page reads that manifest).What is actually downloadable
Nothing in the committed manifest is a downloadable app. GitHub Releases have no assets. This checkout does not contain the Chromium zip, a production Android APK, or current desktop installers. The pages say "Not available" for each platform and do not show a download button or a QR code.
komboe-clientsimage build copies the zip it compiles into the vault and fills the manifest. Unsigned. No store listing. Load-unpacked instructions are linked.komboe-firefox.zipin the artifact directory.Downloads
scripts/build-downloads-manifest.pywritesdistribution/komboe-downloads.json. The vault page andapps/web-marketing/build.pyboth read it. The marketing site also copies it toapps/web-marketing/komboe-downloads.json.docker/Dockerfile.clientsruns the script after it buildskomboe-chrome-mv3.zip, copies the zip into the web vault, and rewrites the manifest. The vault QR is drawn with the bundledqriousscript from that install URL. The marketing page emits a QR only for an absolutehttps://URL, generated locally with no third-party QR service. The same destination is a text link.The public pages are the files in
apps/web-marketing. Putting them on komboe.com is a hosting step. This change does not claim that domain is serving this commit.Branding already on this branch
Terms, Privacy, help, and install links no longer go to bitwarden.com. Web favicons and the empty-vault mark use the Komboe kit. Import format names such as
Bitwarden (json)stay. Cloud API hosts, WebAuthn callbacks, SMTP,ADMIN_TOKEN, and Traefik are unchanged.Checks
python3 tests/features/downloads_manifest.pypassed. It published a fixture zip, downloaded it over HTTP, matched sha2563141b338fe5ee7da23b659dc222207866d0a310aa890e4ce115793fc52db1317, refused a debug APK, decoded a locally generated QR back to that download URL, and checked the marketing page lists every unavailable platform from the same JSON.python3 tests/features/branding_surface.pypassed on the earlier commit (link scan, favicon bytes, route inventory, screenshots). It was updated so the downloads page is no longer required to say "coming soon".Screenshots
Public marketing Downloads page, generated from the shared manifest:
Vault Downloads with nothing published:
Fixture of the publisher after a zip exists. The QR is for that local test file, not a store listing and not the debug APK:
Vault before the onboarding rail was removed:
Still required outside this PR
ghcr.io/godeskio/komboe-clientsfrom this commit, then redeploy, before#/downloadscan servekomboe-chrome-mv3.zip.apps/web-marketingif komboe.com should show this page. No DNS change was made, and the live domain was not verified.Rollback
Revert
71c4b843,69d8236d, andca69ab1a. No schema migration and no account-key change. The previous clients image does not contain this manifest.