Restore angle snapping for discussion - #124
Draft
Gnarus-G wants to merge 19 commits into
Draft
Conversation
On pre-6.11 kernels the handler returns void and cannot communicate a new event count, so injecting synthetic events into the vals buffer is undefined behavior. Restrict ensure_axes_for_rotation() and the memmove injection to __cleanup_events (>= 6.11) only.
* Improve C test reporting * Handle snapshot diff pipe failures
* Add root cause analysis for divide-by-zero kernel panic in maccel_events Add three RCA documents analyzing the #DE divide-by-zero panic in maccel_events (issue #112). The documents cover the fault mechanism where consecutive EV_SYN events with identical ktime_get() timestamps produce a zero divisor in input_speed(), triggering a fatal idivq in interrupt context. Each RCA examines the call path, root causes including unguarded fixed-point divisions and missing parameter validation, and potential fix strategies. * Add tests for division-by-zero and invalid timing guards Add a test for div128_s64_s64 with a zero divisor, running it in a forked child to catch the current SIGFPE trap and assert a clean exit once the guard is implemented. Create a new test suite for acceleration functions that validates survival and correct behavior when given zero or negative time deltas, zero input DPI, and a motivity of exactly one (which produces a zero logarithm divisor). Each case runs in a forked child to prevent the current SIGFPE from killing the test runner. * Add guard tests for division-by-zero kernel panic Encode the safety invariant for maccel#112: division by zero in the fixed-point hot path (time_ms, input_dpi, motivity) must return a defined value, not trap #DE/SIGFPE. Each case runs in a forked child so the current unsafe behavior fails as an assertion instead of core-dumping the suite. Red until the guards are implemented. * Guard fixed-point division and input speed against zero/invalid divisors fpt_div and div128_s64_s64 returned undefined behavior (SIGFPE in userspace, #DE in IRQ context) on a zero divisor. input_speed also divided by time_ms without checking, and left LAST_INPUT_MOUSE_SPEED stale on early return. Return 0 on zero divisor, and return 0 / clear the published speed when time_ms <= 0 or distance calculation fails. Fixes the panic in maccel#112. * Remove outdated RCAs for divide-by-zero kernel panic The root cause analysis documents for issue #112 are no longer relevant as the fix has been implemented. These files contained duplicate and superseded analysis from multiple AI models, and keeping them in the repository would cause confusion about the current state of the fix. * Handle interrupted test child waits
…ishing # Conflicts: # .github/workflows/Release_AUR.yml # AGENTS.md
Expose default Nix package
Remove all installed DKMS versions
Add angle snapping
Automate and publish the AUR package
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
Draft only: do not merge without an explicit maintainer decision and demonstrated user demand.
Context
PR #122 added angle snapping and PR #123 reverted it because the maintenance cost was not justified by a single request; this draft preserves the tested implementation for discussion without shipping it.
Verification
cargo fmt --all --checkcargo test --allmake testmake buildRelated to #107.