Skip to content

Expose default Nix package - #120

Merged
Gnarus-G merged 1 commit into
mainfrom
fix/93-nix-package
Aug 2, 2026
Merged

Expose default Nix package#120
Gnarus-G merged 1 commit into
mainfrom
fix/93-nix-package

Conversation

@Gnarus-G

@Gnarus-G Gnarus-G commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Summary

  • expose the CLI as packages.x86_64-linux.default
  • reuse one package derivation from the flake and NixOS module
  • lock nixpkgs and document profile installation
  • check both the package and enabled module configuration

Verification

  • nix flake check path:/tmp/maccel in nixos/nix:latest

Fixes #93

Summary by CodeRabbit

  • New Features

    • Added Nix packaging for the maccel CLI/TUI.
    • Added a default Nix package and NixOS module support for installing the CLI.
    • Added validation checks for the packaged CLI and NixOS configuration.
  • Documentation

    • Added Quick Start instructions for installing the CLI with nix profile add.
    • Clarified that CLI installation does not include the kernel module; complete driver setup requires the NixOS module.

@vercel

vercel Bot commented Aug 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
maccel Ready Ready Preview Aug 2, 2026 1:15am

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 83f3abc3-0aae-4269-99e7-f4486c9ce462

📥 Commits

Reviewing files that changed from the base of the PR and between 4ebdf1c and befb749.

⛔ Files ignored due to path filters (1)
  • flake.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • README_NIXOS.md
  • flake.nix
  • module.nix
  • package.nix

📝 Walkthrough

Walkthrough

The PR adds a standalone Nix package for maccel-cli, integrates it into the NixOS module, exposes package and check outputs, and documents CLI-only installation with nix profile add.

Changes

Nix CLI packaging and installation

Layer / File(s) Summary
CLI package definition
package.nix
Adds a Rust package derivation for maccel-cli using Cargo.toml, Cargo.lock, and the maccel binary target.
NixOS module package integration
module.nix
Replaces the inline package derivation with pkgs.callPackage ./package.nix {} and removes inline version extraction.
Flake outputs and installation guidance
flake.nix, README_NIXOS.md
Adds CLI package outputs, NixOS module evaluation, validation checks, and CLI installation instructions.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Poem

A rabbit hops through Nix’s new lane,
Builds the CLI without kernel strain.
The module joins, the checks now sing,
Profiles add the useful thing.
maccel-cli is ready to spring!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: exposing the default Nix package.
Linked Issues check ✅ Passed The flake exposes packages.x86_64-linux.default, which addresses issue #93.
Out of Scope Changes check ✅ Passed The documentation, package derivation, module reuse, and flake checks support the stated Nix packaging objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/93-nix-package

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@Gnarus-G
Gnarus-G merged commit c9a4153 into main Aug 2, 2026
4 checks passed
Gnarus-G added a commit that referenced this pull request Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nix error

1 participant