add parent methods to entity#127
add parent methods to entity#127natrim wants to merge 5 commits intoGmodStarfall:developfrom natrim:patch-2
Conversation
|
like this? |
|
You still do not have a check to make sure you do not parent to a player or parenting a player to something. That is problem because, if a player can be parented to say a hologram, that player can be teleported anywhere. I'll ask Colonel, but we need to come up with a standard for error messages, I personally don't like the nil, "error message" approach it is far too easy to miss if something fails. But don't change the error message till I chat with colonel or he replys to this. |
|
Yea the nil, error msg is really bad and inconsistent. At the time, I didn't want functions to immediately fail if the entity is invalid, but looking back on it I think throwing errors on invalid entities would be better (and it would force people to correctly handle those cases) |
|
@daranable - the player check is already there c8bc858 btw. maybe i should change parent() to return nil if the parent is invalid entity? |
|
Oh sorry, didn't see the first of the two commits. |
|
trying to derp it together here https://github.com/natrim/Starfall/tree/library-constraints |
|
remade in #131 |
3 participants
No description provided.