Repository navigation
ci: auto-render crds/ on every same-repo PR, not just renovate - #90
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Fork PRs already need maintainer approval to run workflows (all_external_contributors) and get no secrets. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
hamzabouissi
approved these changes
Sep 29, 2026
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The
render-on-renovatejob re-renderscrds/,charts/*/crds/and theChart.yamlpins, then commits them, but only onrenovate/*branches. On every other PR,verifyfails with "crds/ or Chart.yaml pins are stale" until someone runshack/render.shby hand. The immediate motivation is syncingfeat/otel-20260902(#68) with main: after this change, onlykustomization.yamlneeds editing by hand.What
ci.yaml: removed therenovate/condition, so the job now runs on every PR. Fork PRs already need maintainer approval before any workflow runs (all_external_contributors) and get no secrets, so on a fork PR the job would at worst fail without pushing anything.ci.yaml: the bot's commit message changes tochore: re-render crds/ and Chart.yaml pins. It no longer mentions renovate, and it still passes the conventional-commit check.README.mdand therenovate.jsondescription say the job runs on any same-repo PR, not just renovate branches.Nothing else changes: the job name, the steps and the App token are all the same.
Worth knowing
dismiss_stale_reviews_on_push), just like any other push.🤖 Generated with Claude Code