Skip to content

Fix incorrect identifiers in PAKE operation example code #372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
krish2718 wants to merge 2 commits into
base: main
Choose a base branch
from
+9 −3
Open

Fix incorrect identifiers in PAKE operation example code #372

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01a8c33
Fix incorrect identifiers in the WPA3-SAE example code
krish2718 Jul 12, 2026
5afaea8
Fix incorrect identifier in the SPAKE2+ example code
krish2718 Jul 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions doc/crypto/api/ops/pake.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1852,7 +1852,7 @@ After setup, the key exchange and confirmation flow for SPAKE2+ is as follows.
// Set shareV
psa_pake_input(&spake2p_p, PSA_PAKE_STEP_KEY_SHARE, ...);
// Set confirmV
psa_pake_input(&spake2p_p, PSA_PAKE_STEP_KEY_CONFIRM, ...);
psa_pake_input(&spake2p_p, PSA_PAKE_STEP_CONFIRM, ...);

**Prover**
To get the Prover key confirmation value to send to the Verifier, call:
Expand Down Expand Up @@ -2354,7 +2354,7 @@ Confirm
.. code-block:: xref

// Set send-confirm counter
psa_pake_input(&wpa3_sae, PSA_PAKE_STEP_SEND_CONFIRM, ...);
psa_pake_input(&wpa3_sae, PSA_PAKE_STEP_CONFIRM_COUNT, ...);
// Get combined send-confirm || confirm value
psa_pake_output(&wpa3_sae, PSA_PAKE_STEP_CONFIRM, ...);

Expand Down Expand Up @@ -2392,7 +2392,7 @@ Extract shared secret

// Get K_shared
psa_key_id_t shared_key;
psa_pake_get_shared_key(&spake2p_p, &att, &shared_key);
psa_pake_get_shared_key(&wpa3_sae, &att, &shared_key);

The shared secret that is produced by WPA3-SAE is pseudorandom.
Although it can be used directly as an encryption key, it is recommended to use the shared secret as an input to a key-derivation operation to produce additional cryptographic keys.
Expand Down
6 changes: 6 additions & 0 deletions doc/crypto/appendix/history.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,12 @@ This section provides the detailed changes made between published version of the
Changes in the draft GlobalPlatform publication revision
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Clarifications and fixes
~~~~~~~~~~~~~~~~~~~~~~~~

* Corrected the WPA3-SAE operation example code: the send-confirm counter input step is `PSA_PAKE_STEP_CONFIRM_COUNT`, and the shared key is extracted from the ``wpa3_sae`` operation.
* Corrected the SPAKE2+ operation example code: the Prover input step for the Verifier confirmation value is `PSA_PAKE_STEP_CONFIRM`.

Other changes
~~~~~~~~~~~~~

Expand Down