Fix analyzer DLL import settings before Unity refresh#754
Open
rafay-pk wants to merge 1 commit into
Open
Conversation
Collaborator
|
Should this change include removal of RoslynAnalyzer code from NugetAssetPostprocessor? |
Author
|
It is an early/import-safe bootstrap, not a replacement for the postprocessor. The new installer-side
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes NuGet packages with Roslyn analyzer/source-generator DLLs, such as
MemoryPack.Generator, being imported by Unity as normal plugin assemblies before NuGetForUnity can label them as analyzers.Unity requires analyzer DLLs to have plugin platforms disabled and the
RoslynAnalyzerasset label set. Without the.dll.metafile in place beforeAssetDatabase.Refresh, Unity can try to load analyzer assemblies as runtime assemblies and fail on references such asMicrosoft.CodeAnalysis.Changes
.dll.metageneration inAnalyzerHelperAssetDatabase.RefreshVerification
MemoryPack/MemoryPack.Generatorworks without theMicrosoft.CodeAnalysisplugin load errorsdotnet build src\NuGetForUnity.Cli\NuGetForUnity.Cli.slndotnet test src\NuGetForUnity.Cli\NuGetForUnity.Cli.sln --no-builddotnet build src\NuGetForUnity.PluginAPI\NuGetForUnity.PluginAPI.sln