-
Notifications
You must be signed in to change notification settings - Fork 386
Ability to set the DefineConstraints of packages #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
1d35112
c73edb2
ac83bf2
63d319f
94f4f89
7c7d816
2787331
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -292,6 +292,11 @@ private static string[] ModifyImportSettingsOfGeneralPlugin([NotNull] PackageCon | |
| { | ||
| PluginImporterIsExplicitlyReferencedProperty.SetValue(plugin, !packageConfig.AutoReferenced); | ||
|
|
||
| if (!string.IsNullOrWhiteSpace(packageConfig.DefineConstraints)) | ||
| { | ||
| plugin.DefineConstraints = packageConfig.DefineConstraints.Split(new char[] { ';' }, StringSplitOptions.RemoveEmptyEntries); | ||
| } | ||
|
Comment on lines
+295
to
+298
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good point two options:
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @JoC0de So, regarding the two options this time, I agree with the implementation proposed by Copilot. While the first method seems convenient because it can be configured manually in Unity, considering the concerns mentioned earlier and the implementation required to address them, I question the value of investing that much effort into an option that isn’t used very frequently, as well as the maintenance required for that implementation. It might be a bit of a hassle for users, but isn’t Copilot’s proposed method the more reasonable choice? |
||
|
|
||
| return new[] { ProcessedLabel }; | ||
| } | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.