Add win-arm64, linux-arm64, android-x64, android-arm, ios-x64 to NativeRuntimeSettings.DefaultSettings#729
Add win-arm64, linux-arm64, android-x64, android-arm, ios-x64 to NativeRuntimeSettings.DefaultSettings#729neuecc wants to merge 2 commits into
Conversation
…veRuntimeSettings.DefaultSettings
There was a problem hiding this comment.
Pull request overview
This pull request adds support for additional native runtime identifiers (RIDs) to NativeForUnity's default configuration. The PR addresses missing platform/architecture combinations that prevented certain NuGet packages with native dependencies from being properly imported into Unity projects.
Changes:
- Added support for five new runtime identifiers: win-arm64, linux-arm64, android-x64, android-arm, and ios-x64
- Each new entry is configured with appropriate CPU architecture mappings and BuildTarget settings to ensure proper asset handling in Unity
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| new NativeRuntimeAssetConfiguration("win-arm64", "ARM64", null, "Windows", BuildTarget.StandaloneWindows64), | ||
| new NativeRuntimeAssetConfiguration("linux-x64", "x86_64", "x86_64", "Linux", BuildTarget.StandaloneLinux64), | ||
| new NativeRuntimeAssetConfiguration("linux-arm64", "ARM64", null, "Linux", BuildTarget.StandaloneLinux64), | ||
| new NativeRuntimeAssetConfiguration("android", null, null, null, BuildTarget.Android), | ||
| new NativeRuntimeAssetConfiguration("android-x64", "x86_64", null, null, BuildTarget.Android), | ||
| new NativeRuntimeAssetConfiguration("android-arm", null, null, null, BuildTarget.Android), | ||
| new NativeRuntimeAssetConfiguration("android-arm64", "ARM64", null, null, BuildTarget.Android), | ||
| new NativeRuntimeAssetConfiguration("ios", null, null, null, BuildTarget.iOS), | ||
| new NativeRuntimeAssetConfiguration("ios-x64", "x86_64", null, null, BuildTarget.iOS), |
There was a problem hiding this comment.
The NativeSettingsTest in NuGetTests.cs only tests a subset of runtime configurations (win7-x64, win7-x86, win-x64, win-x86, linux-x64, osx-x64). Consider adding test cases for the newly added runtime configurations (win-arm64, linux-arm64, android-x64, android-arm, ios-x64) to ensure they are properly deserialized and have the expected BuildTarget values.
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
First of all, thank you for the wonderful library. I am actively recommending its use in my OSS projects as well.
While testing libraries that include native runtimes, I confirmed that some packages are not being imported.
This is caused by the absence of entries in NativeRuntimeSettings, and I have also confirmed that there are no issues if overwritten with the corresponding json.
https://github.com/Cysharp/NativeCompressions/blob/6123b5a/sandbox/UnityApp/ProjectSettings/Packages/com.github-glitchenzo.nugetforunity/NativeRuntimeSettings.json
This is a proposal to include support for these (win-arm64, etc.) in the default settings.