Port to Minecraft 26.1.2 (Fabric-only)#65
Closed
grepsedawk wants to merge 1 commit into
Closed
Conversation
Contributor
|
Architectury loom can build 26.1 and up? Did you read the issue you mention? |
Minecraft 26.1 ships deobfuscated, so there are no mappings and no refmap; names are identical at compile time and run time. Native Fabric Loom handles this directly. Architectury Loom has no native 26.1 support yet (architectury-loom#328). You can coax it into building 26.1 through the loom-no-remap variant plus manual shadowJar wiring and access-widener to access-transformer conversion, but that is a pile of hacks to carry. Most people run Fabric, so this drops the multi-loader setup and collapses common/fabric/forge/neoforge into one Fabric module. Much less to maintain. Drop the Architectury and Shadow plugins; bundle sqlite-jdbc with Loom's jar-in-jar instead of shading it. Move to Java 25 and Gradle 9.5.1, both required by 26.1. Fix the API renames the port surfaces: KeyMappingHelper, LevelRenderEvents, ContainerInput, and ChatComponent.addClientSystemMessage.
Author
|
Yes, but not natively and requiring hacks. This just drops support for loaders most people aren't using. Updated commit message to express that part. Also happy to maintain a 26.1 fork in the meantime, or apply these hacks, if that would be preferable. Or, looks like #67 solves the build in an alternative way, too |
Author
|
Closing as dupe of #67 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Ports SnitchMod to Minecraft 26.1.2 as a single Fabric mod.
Why Fabric-only
26.1 ships deobfuscated, so there are no mappings and no refmap; names are identical at compile time and run time. Native Fabric Loom handles this directly.
Architectury Loom has no native 26.1 support yet (architectury-loom#328). You can coax it into building 26.1 through the loom-no-remap variant plus manual shadowJar wiring and access-widener to access-transformer conversion, but that is a pile of hacks to carry. Most people run Fabric, so this drops the multi-loader setup and collapses common/fabric/forge/neoforge into one Fabric module. Much less to maintain.
If keeping Forge/NeoForge matters for this project, say so and I'll redo it multi-loader on the no-remap path instead.
Changes
Rebased on latest main, so the recent text-rendering and auto-scroll fixes are in. Tested in-game by Estalia.