Repository navigation
bug: Count binary patches in review limits - #50
Merged
Merged
Conversation
There was a problem hiding this comment.
✅ OpenAI PR Review: PASS
Conclusion: Ready from the OpenAI review perspective. PR format, linked Issue design, and code/plan conformance passed with no actionable findings.
Review checks
| Check | Result |
|---|---|
| PR format | ✅ PASS |
| Issue design | ✅ PASS |
| Code & plan conformance | ✅ PASS |
Scope: f3f2e03017 · d371c53225..f3f2e03017 · full · 1 diff chunk
Usage: 53s · 270,653 tokens · 78.6% cache hit · credits unavailable
Summary
The complete diff has one reviewed chunk. It conforms to Issue #49’s plan, with no actionable code findings or plan-conformance blockers.
Review metadata
- Commit:
f3f2e03017 - Range:
d371c53225..f3f2e03017 - Mode:
full - Diff chunks:
1 - Model:
gpt-6-sol - Reasoning effort:
low - Session:
repo-1309321116-pr-50-v2 - Generation:
9ab4655615d68316e35a8c30a4b98876d2d4ff9bd311477261a61761cbc886a0 - Evidence:
74947b5417ee19b90ae4662835a8bf31352a95343b8034e3b253c66a66c285d0
Totals
- Input:
268,153 - Cached input:
210,792 - Cache write:
56,545 - Output:
2,500 - Reasoning:
342 - Total:
270,653 - Estimated credits: unavailable for this model
Token and cache details
| Stage | Mode | Target | Time | Input | Cached | Hit | Output | Total | Credits |
|---|---|---|---|---|---|---|---|---|---|
pr |
deterministic |
format rules |
0s | 0 | 0 | 0.0% | 0 | 0 | N/A |
pr |
full |
pr |
11s | 43,345 | 27,783 | 64.1% | 474 | 43,819 | N/A |
issue |
full |
Issue #49 |
19s | 78,523 | 70,494 | 89.8% | 933 | 79,456 | N/A |
code |
full |
chunk 1/1 |
16s | 81,824 | 51,588 | 63.0% | 754 | 82,578 | N/A |
code |
full |
aggregate |
7s | 64,461 | 60,927 | 94.5% | 339 | 64,800 | N/A |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49
Summary
GizClaw/h6infra PR #4 demonstrates the bug: its plain Git patch is 4,147,843 bytes, while
git diff --binaryis 18,621,002 bytes. With this change it requires the existing exact-head admin approval command.Validation
node .github/scripts/pr-review/test.mjsnode .github/scripts/review-request/test.mjsnode .github/scripts/pr-readiness/test.mjsnode .github/scripts/issue-review/test.mjsactionlint -ignore 'property "workflow_(repository|sha)" is not defined' .github/workflows/*.ymlgit diff --check