Repository navigation
fix: Bind restored review sessions to trusted base - #42
Merged
Merged
Conversation
Member
Author
|
@codex review |
Member
Author
|
Self-review added regression coverage preserving prior incremental findings when the model conversation is reset. All four script test suites pass locally. @codex review |
There was a problem hiding this comment.
✅ OpenAI PR Review: PASS
Conclusion: Ready from the OpenAI review perspective. PR format, linked Issue design, and code/plan conformance passed with no actionable findings.
Review checks
| Check | Result |
|---|---|
| PR format | ✅ PASS |
| Issue design | ✅ PASS |
| Code & plan conformance | ✅ PASS |
Scope: f64139f938 · af31372b68..f64139f938 · full · 1 diff chunk
Usage: 58s · 394,860 tokens · 80.3% cache hit · 8.465 credits
Summary
All completed chunk reviews are consistent with Issue #41 and contain no actionable findings or plan-conformance blockers.
Review metadata
- Commit:
f64139f938 - Range:
af31372b68..f64139f938 - Mode:
full - Diff chunks:
1 - Model:
gpt-5.6-terra - Reasoning effort:
medium - Session:
repo-1309321116-pr-42-v2 - Generation:
7a514943327fa9fd009a0f891d81c601c20ab5e92b8f71c792d3b0b9bc8085c3 - Evidence:
a55f70685ddc7dba4f4c712641a278bb0e78c86cb4df56bede3b3d22a761a4ca
Totals
- Input:
390,321 - Cached input:
313,453 - Cache write:
76,826 - Output:
4,539 - Reasoning:
2,349 - Total:
394,860 - Estimated credits:
8.465 - Credit rate per 1M tokens:
62.5input /6.25cached /375output
Token and cache details
| Stage | Mode | Target | Time | Input | Cached | Hit | Output | Total | Credits |
|---|---|---|---|---|---|---|---|---|---|
pr |
deterministic |
format rules |
0s | 0 | 0 | 0.0% | 0 | 0 | 0.000 |
pr |
full |
pr |
7s | 19,902 | 9,533 | 47.9% | 335 | 20,237 | 0.833 |
issue |
full |
Issue #41 |
15s | 82,295 | 67,498 | 82.0% | 1,109 | 83,404 | 1.763 |
code |
full |
chunk 1/1 |
31s | 187,276 | 139,227 | 74.3% | 2,663 | 189,939 | 4.872 |
code |
full |
aggregate |
5s | 100,848 | 97,195 | 96.4% | 432 | 101,280 | 0.998 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #41.
Validation
node .github/scripts/pr-review/test.mjspassed, including same-base resume, changed/missing binding restart, within-run resume and unavailable commit rejection.node .github/scripts/issue-review/test.mjspassed.node .github/scripts/pr-readiness/test.mjspassed.node .github/scripts/review-request/test.mjspassed.git diff --checkpassed.Evidence and release
In GizClaw/gizos run 34753915398, Actions successfully checked out 1f7f5a3e. The restored Codex session instead executed git ls-tree against historical d48cfd97, then mislabeled the resulting error as a missing new base. No checkout permission or untrusted Git-object access is relaxed.
After merge, update the authorized
latesttag and request a fresh GizClaw/gizos#178 review to verify the consuming workflow. This workflow-only fix does not claim firmware acceptance or authorize merging that firmware PR.